feat: ssl-info command to show SSL details and DNS challange records #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the SSL information command for sites, consolidating and improving how SSL and DNS challenge information is displayed. The changes introduce a unified
ssl_infocommand that provides both SSL certificate details and DNS challenge records, along with improved output formatting and error handling.Command and Output Improvements:
Replaces the old
ssl-dns-infocommand with a newssl-infocommand, which now accepts a--get-dns-recordsflag to show DNS challenge records if using DNS-01 challenges. The command description and examples were updated accordingly. [1] [2]Unifies output formatting for both SSL certificate details and DNS challenge records, using a consistent structure and including warnings in the output as needed.
SSL Certificate Details and Error Handling:
Adds logic to display detailed SSL certificate information (such as issuer, subject, validity period, serial number, and SANs) when SSL is enabled, including fallback parsing if
openssl_x509_parseis not available. Warnings are shown for missing or unparsable certificates.Improves error and warning reporting for both DNS challenge extraction and certificate parsing, collecting messages and displaying them in the output instead of logging them immediately. [1] [2]